[GitHub] [spark] cloud-fan commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()
URL: https://github.com/apache/spark/pull/25235#discussion_r311050972
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rpc/RpcEndpointRef.scala
 ##########
 @@ -46,6 +46,17 @@ private[spark] abstract class RpcEndpointRef(conf: SparkConf)
    */
   def send(message: Any): Unit
 
+  /**
+   * Send a message to the corresponding [[RpcEndpoint.receiveAndReply)]] and return a [[Future]] to
+   * receive the reply within the specified timeout.
+   * Return a `CancelableFuture` instance which wrap `Future` but with additional `cancel` method.
+   *
+   * This method only sends the message once and never retries.
+   */
+  def askCancelable[T: ClassTag](message: Any, timeout: RpcTimeout): CancelableFuture[T] = {
 
 Review comment:
   `abort` sounds better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org