You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/24 12:51:41 UTC
[GitHub] [mynewt-nimble] rymanluk opened a new pull request #807: Minor coding style fixes
rymanluk opened a new pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#discussion_r414556308
##########
File path: apps/btshell/src/cmd.c
##########
@@ -2712,7 +2712,7 @@ cmd_security_unpair(int argc, char **argv)
rc = parse_dev_addr("peer_", cmd_peer_addr_types, &peer);
if (rc != 0) {
- console_printf("invalid 'peer_addr' parameter\n");
+ console_printf("invalid 'peer_addr_type' parameter\n");
Review comment:
this is not correct. `parse_dev_addr` will parse both `peer_addr` and `peer_addr_type`, depending on values provided so if we really want to change this I'd rather use generic "peer address" term here. and also there are probably some other places which should be updated in the same way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#issuecomment-619021257
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#issuecomment-619133962
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#issuecomment-619021257
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#discussion_r414556308
##########
File path: apps/btshell/src/cmd.c
##########
@@ -2712,7 +2712,7 @@ cmd_security_unpair(int argc, char **argv)
rc = parse_dev_addr("peer_", cmd_peer_addr_types, &peer);
if (rc != 0) {
- console_printf("invalid 'peer_addr' parameter\n");
+ console_printf("invalid 'peer_addr_type' parameter\n");
Review comment:
this is not correct. `parse_dev_addr` will parse both `peer_addr` and `peer_addr_type`, depending on values provided
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #807: Minor coding style fixes
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #807:
URL: https://github.com/apache/mynewt-nimble/pull/807#discussion_r414553987
##########
File path: apps/blestress/src/tx_stress.c
##########
@@ -1292,14 +1292,14 @@ tx_stress_14_subs_cb(uint16_t conn_handle, const struct ble_gatt_error *error,
assert(error->status == 0);
/* If the first subscription after finding cccd */
- if(arg == NULL) {
+ if (arg == NULL) {
return 0;
}
- sub = (bool*)arg;
+ sub = (bool *) arg;
Review comment:
iirc we do not add space between cast and variable name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org