[GitHub] [accumulo] milleruntime commented on a change in pull request #2372: Exception and cancellation changes in Compactor process

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2372:
URL: https://github.com/apache/accumulo/pull/2372#discussion_r760172587



##########
File path: test/src/main/java/org/apache/accumulo/test/compaction/ExternalDoNothingCompactor.java
##########
@@ -53,6 +53,9 @@ protected Runnable createCompactionJob(TExternalCompactionJob job, LongAdder tot
       LongAdder totalInputBytes, CountDownLatch started, CountDownLatch stopped,
       AtomicReference<Throwable> err) {
 
+    // Set this to true so that only 1 external compaction is run
+    this.shutdown = true;

Review comment:
       Is this the best place to set shutdown to true? Would it be better to set this right before `throw new CompactionCanceledException();`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org