You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by se choi <th...@gmail.com> on 2018/04/09 09:10:01 UTC
Review Request 66502: Update python virtualenv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Update python virtualenv
Diffs
-----
pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
Diff: https://reviews.apache.org/r/66502/diff/1/
Testing
-------
Thanks,
se choi
Re: Review Request 66502: Update python virtualenv
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review200778
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On April 9, 2018, 2:10 a.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 2:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 66502: Update python virtualenv
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review203882
-----------------------------------------------------------
There is an even newer virtualenv version available now. I have filed https://reviews.apache.org/r/67326/ as a replacement and will close this patch now. Sorry for letting this one go stale.
- Stephan Erb
On April 9, 2018, 11:10 a.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 11:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 66502: Update python virtualenv
Posted by se choi <th...@gmail.com>.
> On April 10, 2018, 6:37 p.m., Stephan Erb wrote:
> > Thanks for the patch! We also have another virtulenv version specified here: https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do you think you can bump that one as well?
Homebrew has 5.2.0, wondering if it will work in 5.1.0?
- se
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review200803
-----------------------------------------------------------
On April 9, 2018, 6:10 p.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 6:10 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 66502: Update python virtualenv
Posted by thinker0 <th...@gmail.com>.
Yes, I can do that.
2018년 4월 12일 (목) 오전 6:32, Stephan Erb <se...@apache.org>님이 작성:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
>
> On April 10th, 2018, 11:37 a.m. CEST, *Stephan Erb* wrote:
>
> Thanks for the patch! We also have another virtulenv version specified here: https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do you think you can bump that one as well?
>
> On April 11th, 2018, 8:07 a.m. CEST, *se choi* wrote:
>
> Homebrew has 5.2.0, wondering if it will work in 5.1.0?
>
> Aurora will sometimes need a virtualenv and it will use that script above to download the virtualenv in the specified version. Updating to 15.2.0 should be safe. Homebrew should not be concerned.
>
>
> - Stephan
>
> On April 9th, 2018, 11:10 a.m. CEST, se choi wrote:
> Review request for Aurora.
> By se choi.
>
> *Updated April 9, 2018, 11:10 a.m.*
> *Repository: * aurora
> Description
>
> Update python virtualenv
>
> Diffs
>
> - pants (312dd2035a5ad2e65a1fb3f52d1c36693c2624f0)
>
> View Diff <https://reviews.apache.org/r/66502/diff/1/>
>
Re: Review Request 66502: Update python virtualenv
Posted by Stephan Erb <se...@apache.org>.
> On April 10, 2018, 11:37 a.m., Stephan Erb wrote:
> > Thanks for the patch! We also have another virtulenv version specified here: https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do you think you can bump that one as well?
>
> se choi wrote:
> Homebrew has 5.2.0, wondering if it will work in 5.1.0?
Aurora will sometimes need a virtualenv and it will use that script above to download the virtualenv in the specified version. Updating to 15.2.0 should be safe. Homebrew should not be concerned.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review200803
-----------------------------------------------------------
On April 9, 2018, 11:10 a.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 11:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 66502: Update python virtualenv
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review200803
-----------------------------------------------------------
Thanks for the patch! We also have another virtulenv version specified here: https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do you think you can bump that one as well?
- Stephan Erb
On April 9, 2018, 11:10 a.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 11:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 66502: Update python virtualenv
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66502/#review200724
-----------------------------------------------------------
Ship it!
Master (2d6108b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 9, 2018, 9:10 a.m., se choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66502/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 9:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update python virtualenv
>
>
> Diffs
> -----
>
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
>
>
> Diff: https://reviews.apache.org/r/66502/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> se choi
>
>