You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/28 23:57:10 UTC
[kudu-CR] Add missing include to rwlock-perf.cc
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3527
to review the following change.
Change subject: Add missing include to rwlock-perf.cc
......................................................................
Add missing include to rwlock-perf.cc
Fails to compile on CENTOS 6 without this addition.
Change-Id: I44a574d7b6e89bccfd0ed4f9a95dae30efe25054
---
M src/kudu/experiments/rwlock-perf.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/3527/1
--
To view, visit http://gerrit.cloudera.org:8080/3527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44a574d7b6e89bccfd0ed4f9a95dae30efe25054
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add missing include to rwlock-perf.cc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add missing include to rwlock-perf.cc
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2089/
--
To view, visit http://gerrit.cloudera.org:8080/3527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a574d7b6e89bccfd0ed4f9a95dae30efe25054
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add missing include to rwlock-perf.cc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add missing include to rwlock-perf.cc
......................................................................
Patch Set 1:
I've already made this change here: https://gerrit.cloudera.org/#/c/3496
Still waiting for Todd's +2, though. Or at least for him to say that he's OK with how I incorporated his feedback.
--
To view, visit http://gerrit.cloudera.org:8080/3527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a574d7b6e89bccfd0ed4f9a95dae30efe25054
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add missing include to rwlock-perf.cc
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: Add missing include to rwlock-perf.cc
......................................................................
Abandoned
got merged elsewise
--
To view, visit http://gerrit.cloudera.org:8080/3527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I44a574d7b6e89bccfd0ed4f9a95dae30efe25054
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>