You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/06/13 03:25:19 UTC
[GitHub] [doris] Mryange opened a new pull request, #20734: [fix](profile) remove same profile in join node
Mryange opened a new pull request, #20734:
URL: https://github.com/apache/doris/pull/20734
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588547180
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589121961
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1590347167
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588497336
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589119874
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588481137
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #20734: [fix](profile) remove same profile in join node
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #20734:
URL: https://github.com/apache/doris/pull/20734#discussion_r1227893317
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -450,25 +450,30 @@ Status HashJoinNode::prepare(RuntimeState* state) {
// Build phase
auto record_profile = _should_build_hash_table ? _build_phase_profile : faker_runtime_profile();
- _build_table_timer = ADD_TIMER(record_profile, "BuildTableTime");
- _build_side_merge_block_timer = ADD_TIMER(record_profile, "BuildSideMergeBlockTime");
+ // _build_table_timer = ADD_TIMER(record_profile, "BuildTableTime");
Review Comment:
remove the unless code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589429959
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1590151539
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589917472
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588573029
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588718347
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1590477855
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588708209
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20734: [fix](profile) remove same profile in join node
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20734:
URL: https://github.com/apache/doris/pull/20734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588470292
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588557987
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589289954
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #20734: [fix](profile) remove same profile in join node
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #20734:
URL: https://github.com/apache/doris/pull/20734#discussion_r1227894373
##########
be/src/vec/exec/join/vjoin_node_base.cpp:
##########
@@ -117,8 +117,6 @@ Status VJoinNodeBase::prepare(RuntimeState* state) {
_probe_timer = ADD_TIMER(_probe_phase_profile, "ProbeTime");
_probe_rows_counter = ADD_COUNTER(_probe_phase_profile, "ProbeRows", TUnit::UNIT);
- _build_output_block_timer = ADD_TIMER(runtime_profile(), "BuildOutPutBlockTimer");
Review Comment:
why delete the code？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588493547
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588487496
change the code in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588576929
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1589132474
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588481115
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #20734: [fix](profile) remove same profile in join node
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #20734:
URL: https://github.com/apache/doris/pull/20734#issuecomment-1588480761
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org