You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/07 11:18:18 UTC

[GitHub] [commons-vfs] MaxKellermann commented on pull request #20: AbstractFileObject: call doGetType() without holding the lock

MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-756054642


   > I am not sure if all providers (especialyl external ones) are ready to deal with concurrent invocation of the do method.
   
   That would be a bug in those providers, wouldn't it? Because nowhere can I find a guarantee that there's a lock. It just happens to be here now, as an implementation detail.
   
   > A more compatible change would be some sort of mechanism where only providers willing to opt in for this can use it?
   
   That would make the code more complex, add code duplication, which is error prone. And wouldn't lead anywhere, wouldn't get those (potential) bugs in providers fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org