You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/09 10:44:03 UTC

[GitHub] chetanmeh opened a new pull request #3082: Add dockerignore files to reduce size of build context

chetanmeh opened a new pull request #3082: Add dockerignore files to reduce size of build context
URL: https://github.com/apache/incubator-openwhisk/pull/3082
 
 
   Adds .dockerignore files to 3 docker images which also have scala code. This ensures that build context send to docker daemon only includes required files.
   
   This is based on recommended docker best practice of [using a .dockerignore file][1]. 
   
   Below are the size of build context send prior and post change
    
   - common:scala
   
           Sending build context to Docker daemon  30.32MB //current
           Sending build context to Docker daemon  6.144kB  //post change
   - :core:controller
   
           Sending build context to Docker daemon  65.54MB //current
           Sending build context to Docker daemon  48.74MB //post change
   - :core:invoker
   
           Sending build context to Docker daemon  49.87MB //current
           Sending build context to Docker daemon  45.46MB //post change
   
   This leads to decent saving for common for now. Going forward once Maven artifacts are also build (#3060) then it would ensure that build context does not increase
       
   [1]: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#use-a-dockerignore-file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services