You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:18:35 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1051: feat: support sni based tls route

tao12345666333 commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887441161


##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
                                       type: string
                                       minLength: 1
                                   required:
-                                  - scope
+                                    - scope

Review Comment:
   > I suggest to support yamllint to format those yaml files.
   
   Good idea. I will create new issue for track it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org