You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/12/07 16:46:03 UTC

Review Request 54485: Suppress offers in mesos-execute.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54485/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Repository: mesos


Description
-------

Suppress offers in mesos-execute.


Diffs
-----

  src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47 

Diff: https://reviews.apache.org/r/54485/diff/


Testing
-------

Make check. Manual testing with `mesos-execute`.


Thanks,

James Peach


Re: Review Request 54485: Suppress offers in mesos-execute.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54485/#review158393
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54485]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 7, 2016, 4:46 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54485/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 4:46 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Suppress offers in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47 
> 
> Diff: https://reviews.apache.org/r/54485/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual testing with `mesos-execute`.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 54485: Suppress offers in mesos-execute.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54485/#review158491
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 7, 2016, 4:46 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54485/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 4:46 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Suppress offers in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47 
> 
> Diff: https://reviews.apache.org/r/54485/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual testing with `mesos-execute`.
> 
> 
> Thanks,
> 
> James Peach
> 
>