You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/13 04:50:10 UTC
[GitHub] [druid] rohangarg opened a new pull request, #12640: Support LoadScope for Peons + Access Modifier Updates
rohangarg opened a new pull request, #12640:
URL: https://github.com/apache/druid/pull/12640
The changes contain the following :
1. Supports LoadScope annotation for peons too. As of now, the peons don't report any node role which leads the loadscope logic to not register any module for peons.
2. Update access modifiers in GroupByEngineV2 - they are needed as a part of an internal extension I'm developing on top of Apache Druid.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-cheddar commented on a diff in pull request #12640: Support LoadScope for Peons + Access Modifier Updates
Posted by GitBox <gi...@apache.org>.
imply-cheddar commented on code in PR #12640:
URL: https://github.com/apache/druid/pull/12640#discussion_r895353481
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -301,7 +302,7 @@ public String getTaskIDFromTask(final Task task)
public void run()
{
try {
- Injector injector = makeInjector();
+ Injector injector = makeInjector(ImmutableSet.of(NodeRole.PEON));
Review Comment:
If you are adding this here, you should also remove the binding created lower down in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cheddar merged pull request #12640: Support LoadScope for Peons + Access Modifier Updates
Posted by GitBox <gi...@apache.org>.
cheddar merged PR #12640:
URL: https://github.com/apache/druid/pull/12640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] rohangarg commented on a diff in pull request #12640: Support LoadScope for Peons + Access Modifier Updates
Posted by GitBox <gi...@apache.org>.
rohangarg commented on code in PR #12640:
URL: https://github.com/apache/druid/pull/12640#discussion_r895372583
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -301,7 +302,7 @@ public String getTaskIDFromTask(final Task task)
public void run()
{
try {
- Injector injector = makeInjector();
+ Injector injector = makeInjector(ImmutableSet.of(NodeRole.PEON));
Review Comment:
done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org