You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/02 03:13:58 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
AngersZhuuuu opened a new pull request #31696:
URL: https://github.com/apache/spark/pull/31696
### What changes were proposed in this pull request?
In the PR, I propose to generate "stable" output attributes per the logical node of the DESCRIBE COLUMN command.
### Why are the changes needed?
This fixes the issue demonstrated by the example:
```
val tbl = "testcat.ns1.ns2.tbl"
sql(s"CREATE TABLE $tbl (c0 INT) USING _")
val description = sql(s"DESCRIBE TABLE $tbl c0")
description.drop("info_value")
```
### Does this PR introduce _any_ user-facing change?
After this change user `drop()/add()` works well.
### How was this patch tested?
Added UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788734581
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135644/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789133137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135660/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789133137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135660/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788635886
FYI @cloud-fan @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788939484
**[Test build #135660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135660/testReport)** for PR 31696 at commit [`50b9e0c`](https://github.com/apache/spark/commit/50b9e0ca1168b1cc81dd4b1a331da6526166f7e6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788605741
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40202/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31696:
URL: https://github.com/apache/spark/pull/31696#discussion_r585291618
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -203,12 +203,13 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, _) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended) =>
+ case DescribeColumn(
+ ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) =>
// For views, the column will not be resolved by `ResolveReferences` because
// `ResolvedView` stores only the identifier.
DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended)
Review comment:
> shall we pass the output to the v1 command as well?
You mean unify V2 and v1 DESC command's output? I think v2's `DESC TABLE` need to do this too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789132012
**[Test build #135660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135660/testReport)** for PR 31696 at commit [`50b9e0c`](https://github.com/apache/spark/commit/50b9e0ca1168b1cc81dd4b1a331da6526166f7e6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788566540
**[Test build #135622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135622/testReport)** for PR 31696 at commit [`1b03c95`](https://github.com/apache/spark/commit/1b03c954a352094ca32cc8ba4bf88cd0afe3bd38).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31696:
URL: https://github.com/apache/spark/pull/31696#discussion_r585282588
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -203,12 +203,13 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, _) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended) =>
+ case DescribeColumn(
+ ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) =>
// For views, the column will not be resolved by `ResolveReferences` because
// `ResolvedView` stores only the identifier.
DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended)
Review comment:
shall we pass the output to the v1 command as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788898657
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788939484
**[Test build #135660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135660/testReport)** for PR 31696 at commit [`50b9e0c`](https://github.com/apache/spark/commit/50b9e0ca1168b1cc81dd4b1a331da6526166f7e6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789005653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40241/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789427215
thanks, merging to master/3.1!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788675920
**[Test build #135632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135632/testReport)** for PR 31696 at commit [`2dc21a0`](https://github.com/apache/spark/commit/2dc21a08f7c6579679b1aae3664303ded7d5cb81).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788630816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788675920
**[Test build #135632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135632/testReport)** for PR 31696 at commit [`2dc21a0`](https://github.com/apache/spark/commit/2dc21a08f7c6579679b1aae3664303ded7d5cb81).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788700532
**[Test build #135632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135632/testReport)** for PR 31696 at commit [`2dc21a0`](https://github.com/apache/spark/commit/2dc21a08f7c6579679b1aae3664303ded7d5cb81).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789005653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40241/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788700909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135632/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788630816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788734581
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135644/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788750309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788774859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788582777
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40202/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789430287
> @AngersZhuuuu can you open a backport PR for 3.1?
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788700909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135632/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789427594
@AngersZhuuuu can you open a backport PR for 3.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-789427215
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31696:
URL: https://github.com/apache/spark/pull/31696#discussion_r585298567
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -203,12 +203,13 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, _) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended) =>
+ case DescribeColumn(
+ ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) =>
// For views, the column will not be resolved by `ResolveReferences` because
// `ResolvedView` stores only the identifier.
DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended)
Review comment:
> yea, you can fix it here as well.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31696:
URL: https://github.com/apache/spark/pull/31696#discussion_r585292404
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -203,12 +203,13 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident), partitionSpec, isExtended, _) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended) =>
+ case DescribeColumn(
+ ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) =>
// For views, the column will not be resolved by `ResolveReferences` because
// `ResolvedView` stores only the identifier.
DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended)
Review comment:
yea, you can fix it here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-790258497
https://github.com/apache/spark/pull/31676 doesn't go to 3.0 either. Shall we backport both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788774859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31696:
URL: https://github.com/apache/spark/pull/31696#issuecomment-788702815
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40212/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31696: [SPARK-34576][SQL] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31696:
URL: https://github.com/apache/spark/pull/31696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org