You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2014/11/07 15:25:11 UTC
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/25
CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1
Added Windows Phone 8.1 support
Updated documentation
[JIRA issue](https://issues.apache.org/jira/browse/CB-7970)
[This change](https://github.com/MSOpenTech/cordova-plugin-vibration/compare/CB-7970?expand=1#diff-5db2c860d4e7e5ef74eb7cfc33d99f8eR86) is because `wp` platform does not support `vibrateWithPattern` actually
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-vibration CB-7970
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-vibration/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 69fde4d1a56e6c590fe423f9152e6d1d657ef806
Author: daserge <da...@yandex.ru>
Date: 2014-11-06T16:51:38Z
CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1
Added Windows Phone 8.1 support
Updated documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64450100
There are a few issues here. Strictly saying support is added for Windows Phone 8.1 will confuse users who probably don't know the major underlying differences between what we call a cordova-wp8 app and a cordova-windows ( universal with target of wp8.1 )
We need to be extremely clear about this so users understand.
I would preface the device supports document with : windows ( univeral w/ target --phone ) or something.
I would also like to let this stew a bit, so I can restructure some of the way the windows-universal solution adds c# and c++ code. I find it unwieldy to keep adding projects to the solution, and would like to have a better architecture for this. I will be doing a feature branch to prove the concept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by Jesse <pu...@gmail.com>.
What I meant is, just being able to add a single .js and .cs file instead
of the overhead of dependent projects. You'll have to wait for the proof of
concept though.
@purplecabbage
risingj.com
On Tue, Nov 25, 2014 at 1:10 PM, daserge <gi...@git.apache.org> wrote:
> Github user daserge commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64471333
>
> Hello Jesse,
>
> Thanks for the review, I will update the docs.
> By restructuring do you mean [using csproj instead of winmd](
> https://github.com/apache/cordova-lib/pull/121) component?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64471333
Hello Jesse,
Thanks for the review, I will update the docs.
By restructuring do you mean [using csproj instead of winmd](https://github.com/apache/cordova-lib/pull/121) component?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-86446195
Rebased, tested, merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64683921
I have reviewed the WinJS Globalization API:
~60% of the methods are supported (additional quirks can appear though).
I will also investigate whether [IE11 Globalization API](http://blogs.msdn.com/b/ie/archive/2013/11/11/building-world-ready-applications-in-javascript-using-ie11.aspx) can be used to implement the remaining methods. (It will support Windows 8.1/Windows Phone 8.1 only though)
Links:
- [Globalization preferences](https://code.msdn.microsoft.com/windowsapps/Globalization-preferences-6654eb36)
- [Date and time formatting](https://code.msdn.microsoft.com/windowsapps/Date-and-time-formatting-2361f348)
- [Number formatting](https://code.msdn.microsoft.com/windowsapps/Number-formatting-and-bb10ba3d)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org