You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/11/06 12:21:56 UTC
[GitHub] carbondata pull request #2904: [HOTFIX] Remove search mode module
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2904
[HOTFIX] Remove search mode module
Remove search mode module
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata remove_search
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2904
----
commit 8afa511d7d8c134f7618ca23a252abc9410cd855
Author: Jacky Li <ja...@...>
Date: 2018-11-06T12:19:57Z
remove search module
----
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1553/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1317/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9581/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1340/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2904
retest this please
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9580/
---
[GitHub] carbondata pull request #2904: [HOTFIX] Remove search mode module
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2904
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1364/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9601/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2904
retest this please
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1342/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1329/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2904
It is working now. @ravipesala
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1540/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9588/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2904
LGTM
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1533/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2904
LGTM
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9622/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1574/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1322/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9575/
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2904
@jackylk , it seems to build failed during coverage report after the build. There are few references of `store/search` in the spark-common-test module pom. Please check and remove
---
[GitHub] carbondata issue #2904: [HOTFIX] Remove search mode module
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2904
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1528/
---