[GitHub] [druid] rohangarg commented on a diff in pull request #14400: Adding the test for OR condition in join clause

["rohangarg (via GitHub)" <gi...@apache.org>]

rohangarg commented on code in PR #14400:
URL: https://github.com/apache/druid/pull/14400#discussion_r1228133797


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -5597,7 +5597,12 @@ public void testUnplannableQueries()
         // JOIN condition with a function of both sides.
         "SELECT foo.dim1, foo.dim2, l.k, l.v\n"
         + "FROM foo INNER JOIN lookup.lookyloo l ON CHARACTER_LENGTH(foo.dim2 || l.k) > 3\n",
-        "Possible error: SQL requires a join with 'GREATER_THAN' condition that is not supported."
+        "Possible error: SQL requires a join with 'GREATER_THAN' condition that is not supported.",

Review Comment:
   @pranavbhole : A side cleanup request on this :) 
   Can we move the join related unplannable cases to `CalciteJoinQueryTest` - that class already contains `testJoinOnConstantShouldFail` - we can probably all the join cases together to a single case like this test case. what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org