You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2015/01/27 18:22:35 UTC
[jira] [Comment Edited] (SPARK-5428) Declare the 'assembly' module
at the bottom of the element in the parent POM
[ https://issues.apache.org/jira/browse/SPARK-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293834#comment-14293834 ]
Sean Owen edited comment on SPARK-5428 at 1/27/15 5:21 PM:
-----------------------------------------------------------
I think you have a point there. At least, I don't think it would otherwise hurt anything. Make a pull request?
was (Author: srowen):
I think you have a point there. At least, I don't think it would otherwise hurt anything.
> Declare the 'assembly' module at the bottom of the <modules> element in the parent POM
> --------------------------------------------------------------------------------------
>
> Key: SPARK-5428
> URL: https://issues.apache.org/jira/browse/SPARK-5428
> Project: Spark
> Issue Type: Improvement
> Components: Build, Deploy
> Reporter: Christian Tzolov
> Priority: Trivial
> Labels: assembly, maven, pom
>
> For multiple-modules projects, Maven follows those execution order rules:
> http://maven.apache.org/guides/mini/guide-multiple-modules.html
> If no explicit dependencies are declared Maven will follow the order declared in the <modules> element.
> Because the 'assembly' module is responsible to aggregate build artifacts from other modules/project it make sense to be run last in the execution chain.
> At the moment the 'assembly' stays before modules like 'examples' which makes it impossible to generate DEP package that contains the examples jar.
> IMHO the rule of thumb should be to keep the 'assembly' module as the last element in the <modules> list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org