[GitHub] [spark] mridulm commented on a diff in pull request #40307: [DRAFT][CORE][SHUFFLE]: SPARK-42689: Allow ShuffleDriverComponent to declare if shuffle data is reliably stored

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #40307:
URL: https://github.com/apache/spark/pull/40307#discussion_r1126939110


##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -596,6 +591,13 @@ class SparkContext(config: SparkConf) extends Logging {
       _conf.set(APP_ATTEMPT_ID, attemptId)
       _env.blockManager.blockStoreClient.setAppAttemptId(attemptId)
     }
+
+    // initialize after application id and attempt id has been initialized

Review Comment:
   Shuffle driver components typically depend on the application/attempt id for managing their metadata.
   Initializing it after these values are set in `SparkConcext` allows the `ShuffleDriverComponents` to rely on this - instead of using hacks like `SparkListener` waiting for application start, etc for the actual initialization.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org