You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/14 21:12:55 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26106:
[SPARK-29454][SQL] Reduce unsafeProjection times when read Parquet file
dongjoon-hyun commented on a change in pull request #26106: [SPARK-29454][SQL] Reduce unsafeProjection times when read Parquet file
URL: https://github.com/apache/spark/pull/26106#discussion_r334664785
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
##########
@@ -328,32 +328,28 @@ class ParquetFileFormat
iter.asInstanceOf[Iterator[InternalRow]]
} else {
logDebug(s"Falling back to parquet-mr")
Review comment:
So, is this PR aiming only for non-vectorized code, @LuciferYang ? If then, please update the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org