You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/27 03:55:51 UTC

[GitHub] [ozone] JacksonYao287 opened a new pull request #2588: HDDS-5687. support Option as parameters of commandLine

JacksonYao287 opened a new pull request #2588:
URL: https://github.com/apache/ozone/pull/2588


   ## What changes were proposed in this pull request?
   
   we have introduced Optional<T> as parameters of CommandLine in container balancer. According to [the official doc](https://picocli.info/#_optionalt), from From picocli version 4.6, it is supported. so this PR just bump the version to that.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5687
   
   ## How was this patch tested?
   
   no need to add more tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on pull request #2588: HDDS-5687. support Optional as parameters of commandLine

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2588:
URL: https://github.com/apache/ozone/pull/2588#issuecomment-907044514


   Thanks @lokeshj1703 for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on pull request #2588: HDDS-5687. support Option as parameters of commandLine

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2588:
URL: https://github.com/apache/ozone/pull/2588#issuecomment-906905120


   @lokeshj1703 @ChenSammi PTAL!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] lokeshj1703 commented on pull request #2588: HDDS-5687. support Optional as parameters of commandLine

Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #2588:
URL: https://github.com/apache/ozone/pull/2588#issuecomment-907056375


   @JacksonYao287 Thanks for the contribution! I have committed the PR to master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] lokeshj1703 merged pull request #2588: HDDS-5687. support Optional as parameters of commandLine

Posted by GitBox <gi...@apache.org>.
lokeshj1703 merged pull request #2588:
URL: https://github.com/apache/ozone/pull/2588


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org