You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ammachado (via GitHub)" <gi...@apache.org> on 2026/05/11 19:53:01 UTC

[PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

ammachado opened a new pull request, #23127:
URL: https://github.com/apache/camel/pull/23127

   # Description
   
   Introduce `ContentCacheAware` SPI so resource-based components can opt into
   having their content cache set to false when `camel.main.routesReloadEnabled`
   is set to `true` (set automatically by `camel run --dev`). A new
   `DevModeContentCacheStrategy` applies the setting on component registration,
   and explicit user settings on the component, endpoint or URI are always respected.
   
   `camel-xslt` is the first adopter: `XsltComponent` now implements `ContentCacheAware`
   and stores `contentCache` as a Boolean (null = unset). Other resource-based
   components can be migrated in a follow-up.
   
   Co-Authored-By: Claude Opus 4.7 <no...@anthropic.com>
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
   
   # Tracking
   
   - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   - [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #23127:
URL: https://github.com/apache/camel/pull/23127#discussion_r3221768013


##########
components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltComponent.java:
##########
@@ -94,6 +95,11 @@ public void setAllowTemplateFromHeader(boolean allowTemplateFromHeader) {
     }
 
     public boolean isContentCache() {
+        return contentCache != null ? contentCache : true;
+    }
+
+    @Override
+    public Boolean getContentCache() {
         return contentCache;
     }
 

Review Comment:
   `XsltComponent` now exposes *both* `isContentCache(): boolean` and `getContentCache(): Boolean` for the same property name, while the setter is `setContentCache(Boolean)`. This can confuse JavaBeans introspection/binders (some prefer `isXxx` for booleans) and may result in a read-only `contentCache` property or failed binding in frameworks that rely on standard property descriptors. A concrete fix is to restore JavaBeans compatibility by adding an overload `setContentCache(boolean)` delegating to the `Boolean` setter (or alternatively rename `isContentCache()` to something like `isContentCacheEnabled()` / `isContentCacheEffective()` so the bean property is unambiguous).
   



##########
components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltComponent.java:
##########
@@ -102,7 +108,8 @@ public boolean isContentCache() {
      * stylesheet file on each message processing. This is good for development. A cached stylesheet can be forced to
      * reload at runtime via JMX using the clearCachedStylesheet operation.
      */
-    public void setContentCache(boolean contentCache) {
+    @Override
+    public void setContentCache(Boolean contentCache) {
         this.contentCache = contentCache;
     }

Review Comment:
   `XsltComponent` now exposes *both* `isContentCache(): boolean` and `getContentCache(): Boolean` for the same property name, while the setter is `setContentCache(Boolean)`. This can confuse JavaBeans introspection/binders (some prefer `isXxx` for booleans) and may result in a read-only `contentCache` property or failed binding in frameworks that rely on standard property descriptors. A concrete fix is to restore JavaBeans compatibility by adding an overload `setContentCache(boolean)` delegating to the `Boolean` setter (or alternatively rename `isContentCache()` to something like `isContentCacheEnabled()` / `isContentCacheEffective()` so the bean property is unambiguous).



##########
core/camel-main/src/test/java/org/apache/camel/main/MainDevModeContentCacheTest.java:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.main;
+
+import java.util.Map;
+
+import org.apache.camel.Endpoint;
+import org.apache.camel.spi.ContentCacheAware;
+import org.apache.camel.support.DefaultComponent;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+public class MainDevModeContentCacheTest {
+
+    @Test
+    public void shouldDisableContentCacheWhenRoutesReloadEnabled() {
+        Main main = new Main();
+        main.configure().withRoutesReloadEnabled(true);
+        main.bind("dummy", new TestContentCacheComponent());
+
+        main.start();
+        try {
+            TestContentCacheComponent c = main.getCamelContext().getComponent("dummy", TestContentCacheComponent.class);
+            assertEquals(Boolean.FALSE, c.getContentCache(),
+                    "contentCache should be auto-disabled when routesReloadEnabled=true");
+        } finally {
+            main.stop();
+        }
+    }
+
+    @Test
+    public void shouldLeaveContentCacheUnsetWhenRoutesReloadDisabled() {
+        Main main = new Main();
+        // routesReloadEnabled defaults to false
+        main.bind("dummy", new TestContentCacheComponent());
+
+        main.start();
+        try {
+            TestContentCacheComponent c = main.getCamelContext().getComponent("dummy", TestContentCacheComponent.class);
+            assertNull(c.getContentCache(),
+                    "contentCache should remain unset when routesReloadEnabled is not active");
+        } finally {
+            main.stop();
+        }
+    }
+
+    @Test
+    public void shouldRespectExplicitContentCacheTrue() {
+        Main main = new Main();
+        main.configure().withRoutesReloadEnabled(true);
+        TestContentCacheComponent component = new TestContentCacheComponent();
+        component.setContentCache(Boolean.TRUE);
+        main.bind("dummy", component);
+
+        main.start();
+        try {
+            TestContentCacheComponent c = main.getCamelContext().getComponent("dummy", TestContentCacheComponent.class);
+            assertEquals(Boolean.TRUE, c.getContentCache(),
+                    "explicit user setting must not be overridden by dev-mode auto-flip");
+        } finally {
+            main.stop();
+        }
+    }
+
+    @Test
+    public void shouldRespectExplicitContentCacheFalse() {
+        Main main = new Main();
+        main.configure().withRoutesReloadEnabled(true);
+        TestContentCacheComponent component = new TestContentCacheComponent();
+        component.setContentCache(Boolean.FALSE);
+        main.bind("dummy", component);
+
+        main.start();
+        try {
+            TestContentCacheComponent c = main.getCamelContext().getComponent("dummy", TestContentCacheComponent.class);
+            assertEquals(Boolean.FALSE, c.getContentCache());
+        } finally {
+            main.stop();
+        }
+    }
+
+    public static final class TestContentCacheComponent extends DefaultComponent implements ContentCacheAware {
+
+        private Boolean contentCache;
+
+        @Override
+        public Boolean getContentCache() {
+            return contentCache;
+        }
+
+        @Override
+        public void setContentCache(Boolean contentCache) {
+            this.contentCache = contentCache;
+        }
+
+        @Override
+        protected Endpoint createEndpoint(String uri, String remaining, Map<String, Object> parameters) {
+            return null;

Review Comment:
   `DefaultComponent#createEndpoint(...)` is expected to return a non-null `Endpoint`. Returning `null` can cause hard-to-diagnose NPEs if the test is later extended (or if Camel behavior changes to create an endpoint during startup). Prefer throwing `UnsupportedOperationException` (to fail fast) or returning a minimal stub `Endpoint` implementation.
   



##########
core/camel-main/src/main/java/org/apache/camel/main/DevModeContentCacheStrategy.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.main;
+
+import org.apache.camel.Component;
+import org.apache.camel.spi.ContentCacheAware;
+import org.apache.camel.support.LifecycleStrategySupport;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Lifecycle strategy that disables content caching on resource-based components when routes-reload is enabled. Lets
+ * users edit a resource file (e.g. an XSLT stylesheet) and see the change applied live, without having to set
+ * {@code contentCache=false} on every endpoint.
+ *
+ * Only flips components that have not been explicitly configured by the user (i.e.
+ * {@link ContentCacheAware#getContentCache()} returns {@code null}); explicit user settings are preserved.
+ */
+public class DevModeContentCacheStrategy extends LifecycleStrategySupport {
+
+    private static final Logger LOG = LoggerFactory.getLogger(DevModeContentCacheStrategy.class);
+
+    @Override
+    public void onComponentAdd(String name, Component component) {
+        if (component instanceof ContentCacheAware aware && aware.getContentCache() == null) {
+            aware.setContentCache(Boolean.FALSE);
+            LOG.info("Routes-reload is enabled: disabling contentCache on component '{}' for live resource reload",
+                    name);
+        }

Review Comment:
   The PR description states that explicit user settings “on the component, endpoint, or URI are always respected”, but the added tests only cover explicit *component-level* settings. Add a unit test that exercises endpoint/URI configuration overriding the auto-flipped component default (e.g., create a minimal component+endpoint pair where the endpoint has `contentCache` set from URI parameters and assert it remains `true` when `routesReloadEnabled=true`).



##########
core/camel-main/src/main/java/org/apache/camel/main/DevModeContentCacheStrategy.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.main;
+
+import org.apache.camel.Component;
+import org.apache.camel.spi.ContentCacheAware;
+import org.apache.camel.support.LifecycleStrategySupport;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Lifecycle strategy that disables content caching on resource-based components when routes-reload is enabled. Lets
+ * users edit a resource file (e.g. an XSLT stylesheet) and see the change applied live, without having to set
+ * {@code contentCache=false} on every endpoint.
+ *
+ * Only flips components that have not been explicitly configured by the user (i.e.
+ * {@link ContentCacheAware#getContentCache()} returns {@code null}); explicit user settings are preserved.
+ */
+public class DevModeContentCacheStrategy extends LifecycleStrategySupport {
+
+    private static final Logger LOG = LoggerFactory.getLogger(DevModeContentCacheStrategy.class);
+
+    @Override
+    public void onComponentAdd(String name, Component component) {
+        if (component instanceof ContentCacheAware aware && aware.getContentCache() == null) {
+            aware.setContentCache(Boolean.FALSE);
+            LOG.info("Routes-reload is enabled: disabling contentCache on component '{}' for live resource reload",

Review Comment:
   Logging this at `INFO` will emit one line per `ContentCacheAware` component added, which can be noisy in dev mode (and especially as more components adopt the SPI). Consider lowering to `DEBUG`, or logging once with a summary (or guard with a “log once per component name” mechanism) to reduce log volume while keeping the behavior discoverable.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23127:
URL: https://github.com/apache/camel/pull/23127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #23127:
URL: https://github.com/apache/camel/pull/23127#issuecomment-4428937919

   @ammachado there are uncommitted changes
   ```
   There are uncommitted changes
   HEAD detached at pull/23127/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/XjComponentBuilderFactory.java
   	modified:   dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/XsltComponentBuilderFactory.java
   	modified:   dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/XsltSaxonComponentBuilderFactory.java
   ```
   
   You can `cd dsl && man clean install -DskipTests` once camel-xslt is built locally to quickly generate those files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #23127:
URL: https://github.com/apache/camel/pull/23127#issuecomment-4430121784

   **Alternative approach worth considering: use the existing `PropertyConfigurer` API instead of a new SPI**
   
   Rather than introducing `ContentCacheAware` in `camel-api` and migrating components one by one, the `DevModeContentCacheStrategy` could use the existing generated `PropertyConfigurer` to detect and set the `contentCache` property on any component that has it:
   
   ```java
   @Override
   public void onComponentAdd(String name, Component component) {
       PropertyConfigurer configurer = PluginHelper.getConfigurerResolver(component.getCamelContext())
           .resolvePropertyConfigurer(name + "-component", component.getCamelContext());
       if (configurer instanceof PropertyConfigurerGetter getter) {
           Object val = getter.getOptionValue(component, "contentCache", true);
           if (Boolean.TRUE.equals(val)) {
               configurer.configure(component.getCamelContext(), component, "contentCache", false, true);
               LOG.info("Routes-reload is enabled: disabling contentCache on component '{}' for live resource reload", name);
           }
       }
   }
   ```
   
   **Advantages:**
   - No new SPI interface in `camel-api` (smaller API surface)
   - Works immediately for **all ~13 components** with `contentCache` (freemarker, velocity, mustache, jte, jolt, jslt, jsonata, json-validator, json-patch, mvel, chunk, stringtemplate, language) — no per-component migration needed
   - No `boolean` → `Boolean` field change, so no binary compatibility concern
   - The timing works for the common case: user properties via `camel.component.<name>.contentCache=true` are bound *after* `onComponentAdd`, so they naturally override the strategy's change
   
   **Downside:**
   - Cannot distinguish "default `true`" from "user explicitly set `true` programmatically before adding the component to the context" (e.g., `component.setContentCache(true); context.addComponent(...)`). The strategy would wrongly override it in that scenario. The tri-state `Boolean` (null = unset) in the current PR handles this edge case correctly.
   - That said, programmatic pre-registration configuration is uncommon with Camel Main, which is the primary consumer of this feature.
   
   Not a blocker — just flagging the trade-off for consideration.
   
   _Claude Code on behalf of Guillaume Nodet_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #23127:
URL: https://github.com/apache/camel/pull/23127#discussion_r3224052344


##########
core/camel-main/src/main/java/org/apache/camel/main/DevModeContentCacheStrategy.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.main;
+
+import org.apache.camel.Component;
+import org.apache.camel.spi.ContentCacheAware;
+import org.apache.camel.support.LifecycleStrategySupport;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Lifecycle strategy that disables content caching on resource-based components when routes-reload is enabled. Lets
+ * users edit a resource file (e.g. an XSLT stylesheet) and see the change applied live, without having to set
+ * {@code contentCache=false} on every endpoint.
+ *
+ * Only flips components that have not been explicitly configured by the user (i.e.
+ * {@link ContentCacheAware#getContentCache()} returns {@code null}); explicit user settings are preserved.
+ */
+public class DevModeContentCacheStrategy extends LifecycleStrategySupport {

Review Comment:
   Nit: this class is only instantiated from `DefaultConfigurationConfigurer` in the same package. Consider reducing visibility to package-private:
   
   ```suggestion
   class DevModeContentCacheStrategy extends LifecycleStrategySupport {
   ```



##########
components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltComponent.java:
##########
@@ -102,7 +108,8 @@ public boolean isContentCache() {
      * stylesheet file on each message processing. This is good for development. A cached stylesheet can be forced to
      * reload at runtime via JMX using the clearCachedStylesheet operation.
      */
-    public void setContentCache(boolean contentCache) {
+    @Override
+    public void setContentCache(Boolean contentCache) {
         this.contentCache = contentCache;
     }

Review Comment:
   The `setContentCache(boolean)` → `setContentCache(Boolean)` signature change breaks binary backward compatibility (JVM method descriptor changes from `(Z)V` to `(Ljava/lang/Boolean;)V`). Existing compiled code calling `component.setContentCache(true)` would get a `NoSuchMethodError` at runtime.
   
   Consider keeping the old `boolean` overload as a deprecated bridge:
   
   ```suggestion
       @Override
       public void setContentCache(Boolean contentCache) {
           this.contentCache = contentCache;
       }
   
       /**
        * @deprecated use {@link #setContentCache(Boolean)}
        */
       @Deprecated
       public void setContentCache(boolean contentCache) {
           this.contentCache = contentCache;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23127:
URL: https://github.com/apache/camel/pull/23127#issuecomment-4433920790

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-xslt`
   - `core/camel-main`
   - `docs`
   
   > :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
   
   <details><summary>Build reactor — dependencies compiled but only changed modules were tested (3 modules)</summary>
   
   - Camel :: Docs
   - Camel :: Main
   - Camel :: XSLT
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25746880435)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "ammachado (via GitHub)" <gi...@apache.org>.
ammachado commented on code in PR #23127:
URL: https://github.com/apache/camel/pull/23127#discussion_r3227998744


##########
components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltComponent.java:
##########
@@ -102,7 +108,8 @@ public boolean isContentCache() {
      * stylesheet file on each message processing. This is good for development. A cached stylesheet can be forced to
      * reload at runtime via JMX using the clearCachedStylesheet operation.
      */
-    public void setContentCache(boolean contentCache) {
+    @Override
+    public void setContentCache(Boolean contentCache) {
         this.contentCache = contentCache;
     }

Review Comment:
   Using `PropertyConfigurer` implementation instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23127:
URL: https://github.com/apache/camel/pull/23127#issuecomment-4427642517

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23302: camel-xslt - Auto-disable content cache in routes-reload (dev) mode [camel]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on code in PR #23127:
URL: https://github.com/apache/camel/pull/23127#discussion_r3225070881


##########
components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltComponent.java:
##########
@@ -45,7 +46,7 @@ public class XsltComponent extends DefaultComponent {
     @Metadata
     private boolean allowTemplateFromHeader;
     @Metadata(defaultValue = "true")
-    private boolean contentCache = true;
+    private Boolean contentCache;

Review Comment:
   isn't the default false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org