You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/03/03 20:43:09 UTC
[PR] Fix install instructions after switching www -> ui [airflow]
potiuk opened a new pull request, #47314:
URL: https://github.com/apache/airflow/pull/47314
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install instructions after switching www -> ui [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #47314:
URL: https://github.com/apache/airflow/pull/47314#discussion_r1978260153
##########
INSTALL:
##########
@@ -133,6 +133,38 @@ You can also synchronize all extras:
uv sync --all-extras
+Compiling front-end assets
+--------------------------
+
+In order to see UI in Airflow, you need to compile front-end assets. You can do it after installing
+node and pnpm and running (in `airflow/ui` directory):
+
+ pnpm install -frozen-lockfile --config.confirmModulesPurge=false
+ pnpm run build
+
+if you want to manually run the build check for node and pnpm version in `.pre-commit-config.yaml` file,
Review Comment:
```suggestion
If you want to manually run the build check for node and pnpm version in `.pre-commit-config.yaml` file,
```
##########
INSTALL:
##########
@@ -133,6 +133,38 @@ You can also synchronize all extras:
uv sync --all-extras
+Compiling front-end assets
+--------------------------
+
+In order to see UI in Airflow, you need to compile front-end assets. You can do it after installing
+node and pnpm and running (in `airflow/ui` directory):
+
+ pnpm install -frozen-lockfile --config.confirmModulesPurge=false
+ pnpm run build
+
+if you want to manually run the build check for node and pnpm version in `.pre-commit-config.yaml` file,
+but there are semi-automatic ways to build the assets.
+
+In case you use `breeze` or have `pre-commit` installed (see `contributing-docs` quick-start), you can
+build the assets with the following commands:
+
+ pre-commit run --hook-stage manual compile-ui-assets --all-files
+
+or
+
+ breeze compile-ui-assets
+
+Both commands will install node and pmpm under the hook, if needed, to a dedicated pre-commit
+node environment and then build the assets.
+
+Finally, you can also clean and recompile assets with `custom` build target when running the Hatch build
Review Comment:
```suggestion
Finally, you can also clean and recompile assets with `custom` build target when running the Hatch build:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install instructions after switching www -> ui [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #47314:
URL: https://github.com/apache/airflow/pull/47314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org