You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/12/01 15:54:19 UTC
[GitHub] [cordova-cli] yeli19950109 opened a new pull request #567: fix:support macOS 12 monterey
yeli19950109 opened a new pull request #567:
URL: https://github.com/apache/cordova-cli/pull/567
update insight version
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
macos 12+
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/cordova-cli/issues/566
### Description
<!-- Describe your changes in detail -->
support macOS 12 monterey
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu commented on pull request #567: fix:update insight to support macOS 12 monterey
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #567:
URL: https://github.com/apache/cordova-cli/pull/567#issuecomment-996592350
Thank you for your PR and work.
I went ahead and merged in #573 which updated the insight dependency but also updated the `package-lock.json` and code usage that this PR was missing. There was a breaking change in the update that this PR was not handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu closed pull request #567: fix:update insight to support macOS 12 monterey
Posted by GitBox <gi...@apache.org>.
erisu closed pull request #567:
URL: https://github.com/apache/cordova-cli/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org