[GitHub] [iceberg] jackye1995 commented on a change in pull request #2096: Core: add schema id and schemas to table metadata

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r570459069



##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -157,6 +157,21 @@ public static Schema assignFreshIds(Schema schema, NextID nextId) {
         .fields());
   }
 
+  /**
+   * Assigns fresh ids from the {@link NextID nextId function} for all fields in a schema.

Review comment:
       nit: function should be outside the bracket

##########
File path: core/src/main/java/org/apache/iceberg/SchemaParser.java
##########
@@ -134,6 +143,10 @@ static void toJson(Type type, JsonGenerator generator) throws IOException {
     }
   }
 
+  public static void toJsonWithVersion(Schema schema, JsonGenerator generator) throws IOException {

Review comment:
       nit: should this be called `toJsonWithId`, just to match the `fromJsonWithId` below?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org