You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ccorcos <gi...@git.apache.org> on 2017/08/22 18:46:17 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request #42: Dynamic swipe back enabled...
GitHub user ccorcos opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
Dynamic swipe back enabled preference
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine swipe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit e67392fd53e6f0efb9d000be109b61ec6a889a09
Author: Chet Corcos <cc...@gmail.com>
Date: 2017-08-22T18:32:27Z
Dynamic swipe back enabled preference
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
Alright @shazron made those changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615068
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -457,6 +457,19 @@ - (void) webView: (WKWebView *) webView decidePolicyForNavigationAction: (WKNavi
return decisionHandler(NO);
}
+#pragma mark - Plugin interface
+
+- (void)allowsBackForwardNavigationGestures:(CDVInvokedUrlCommand*)command;
+{
+ id value = [command.arguments objectAtIndex:0];
--- End diff --
I would use either of these commands: https://github.com/apache/cordova-ios/blob/077b1dc3c1d72ade9552773ed5a3a4c817800d37/CordovaLib/Classes/Public/CDVInvokedUrlCommand.h#L46-L50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
Also, make sure that `npm run eslint` passes -- this is causing Travis CI to fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
ping @shazron
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615278
--- Diff: src/www/ios/ios-wkwebview.js ---
@@ -0,0 +1,9 @@
+var exec = require('cordova/exec');
+
+const WkWebKit = {
--- End diff --
I wouldn't use ES6 `const` here, since ES6 is only supported in iOS 10 webviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org