[GitHub] [tinkerpop] dkuppitz commented on issue #1266: TINKERPOP-2351 Fixed bug in Order when enum is a key in Map

[GitBox <gi...@apache.org>]

dkuppitz commented on issue #1266: TINKERPOP-2351 Fixed bug in Order when enum is a key in Map
URL: https://github.com/apache/tinkerpop/pull/1266#issuecomment-601503606
 
 
   My first thought was that the general rule rather be: If `a` and `b` have different (non-numeric) types, use the `toString()` value for both, otherwise:
   
   ```
   gremlin> g.V().map(properties().group().by(value).by(key()))
   ==>[29:age,marko:name]
   ==>[vadas:name,27:age]
   ==>[java:lang,lop:name]
   ==>[32:age,josh:name]
   ==>[java:lang,ripple:name]
   ==>[35:age,peter:name]
   gremlin> g.V().map(properties().group().by(value).by(key)).order(local).by(keys, desc)
   java.lang.String cannot be cast to java.lang.Integer
   ```
   
   But then, taking Groovy as a reference, it probably shouldn't work this way.
   
   ```
   gremlin> [id:'1','b':2,'z':3].sort()
   ==>b=2
   ==>id=1
   ==>z=3
   gremlin> [id:'1','b':2,3:3].sort()
   java.lang.String cannot be cast to java.lang.Integer
   Type ':help' or ':h' for help.
   Display stack trace? [yN]
   ```
   
   Thus, +1 on that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services