[GitHub] [doris] morrySnow commented on a diff in pull request #20044: [Function] Support date function: microsecond()

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #20044:
URL: https://github.com/apache/doris/pull/20044#discussion_r1226036026


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -304,7 +304,7 @@ valueExpression
 datetimeUnit
     : YEAR | MONTH
     | WEEK | DAY
-    | HOUR | MINUTE | SECOND
+    | HOUR | MINUTE | SECOND | MICROSECOND

Review Comment:
   do not add this, if u do not want to implement dateAdd / dateSub / timestampDiff function in MICROSECOND unit



##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -418,7 +418,7 @@ interval
     ;
 
 unitIdentifier
-    : YEAR | MONTH | WEEK | DAY | HOUR | MINUTE | SECOND
+    : YEAR | MONTH | WEEK | DAY | HOUR | MINUTE | SECOND | MICROSECOND

Review Comment:
   do not add this, if u do not want to add MICROSECOND interval literal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org