[jira] [Resolved] (STORM-2345) Type mismatch in ReadClusterState's ProfileAction processing Map

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jungtaek Lim resolved STORM-2345.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.4
                   1.1.0
                   2.0.0

Thanks [~tibor.kiss@gmail.com], I merged into master, 1.x, 1.0.x branches.

> Type mismatch in ReadClusterState's ProfileAction processing Map
> ----------------------------------------------------------------
>
>                 Key: STORM-2345
>                 URL: https://issues.apache.org/jira/browse/STORM-2345
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 2.0.0, 1.0.3, 1.x
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>            Priority: Trivial
>             Fix For: 2.0.0, 1.1.0, 1.0.4
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Discovered during reading STORM-2018's review comments:
> {{ReadClusterState.run()}} method loads all the profiling requests from Zk then filters the ones designated to that particular node it runs on.  
> The filtered profiling requests are stored in a Map: {{Map<Integer, Set<TopoProfileAction>>}} on a per Slot basis.
> For some reason the TCP Port is serialized as i64/Long in NodeInfo, which is later used as a key in the Map.
> The Map.put is converted properly to Integer, but the Map.get does not, causing the lookups to report a miss in the {{filtered}} Map.
> This could cause TopoProfileActions ignored if one would send multiple TopoProfileActions through Zk. 
> I don't think that could normally happen (using the UI), but the fix is trivial.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)