You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/11/03 22:12:58 UTC
[PR] [SPARK-50211][PYTHON][CONNECT][TESTS] Skip FeatureTests if torch is not installed [spark]
HyukjinKwon opened a new pull request, #48743:
URL: https://github.com/apache/spark/pull/48743
### What changes were proposed in this pull request?
This PR proposes to skip FeatureTests if torch is not installed
### Why are the changes needed?
If tourch isn't available, we should run the tests `FeatureTests `. That's an optional dependency.
To fix Python 3.13 build
https://github.com/apache/spark/actions/runs/11654255828/job/32447601706
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Manually tested.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50211][PYTHON][CONNECT][TESTS] Skip FeatureTests if torch is not installed [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48743:
URL: https://github.com/apache/spark/pull/48743#issuecomment-2453632228
Merged to master. Thank you, @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50211][PYTHON][CONNECT][TESTS] Skip FeatureTests if torch is not installed [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #48743: [SPARK-50211][PYTHON][CONNECT][TESTS] Skip FeatureTests if torch is not installed
URL: https://github.com/apache/spark/pull/48743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org