You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2011/09/08 00:23:08 UTC
[jira] [Created] (CASSANDRA-3152) Logic of
AbstractNetworkTopologySnitch.compareEndpoints is wrong
Logic of AbstractNetworkTopologySnitch.compareEndpoints is wrong
----------------------------------------------------------------
Key: CASSANDRA-3152
URL: https://issues.apache.org/jira/browse/CASSANDRA-3152
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.8.4
Environment: JVM
Reporter: Vijay
Assignee: Vijay
Fix For: 0.8.5
Current logic in ANTS.cE is to compare the rack and then compare the DC's, the problem is when we have the same rack name but the racks are in a diffrent DC's this logic breaks...
Example:
"us-east,1a", InetAddress.getByName("127.0.0.1")
"us-east,1b", InetAddress.getByName("127.0.0.2")
"us-east,1c", InetAddress.getByName("127.0.0.3")
"us-west,1a", InetAddress.getByName("127.0.0.4")
"us-west,1b", InetAddress.getByName("127.0.0.5")
"us-west,1c", InetAddress.getByName("127.0.0.6")
Expected:
/127.0.0.1,/127.0.0.3,/127.0.0.2,/127.0.0.4,/127.0.0.5,/127.0.0.6
Current:
/127.0.0.1,/127.0.0.4,/127.0.0.3,/127.0.0.2,/127.0.0.5,/127.0.0.6
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3152) Logic of
AbstractNetworkTopologySnitch.compareEndpoints is wrong
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3152:
--------------------------------------
Priority: Minor (was: Major)
Affects Version/s: (was: 0.8.4)
> Logic of AbstractNetworkTopologySnitch.compareEndpoints is wrong
> ----------------------------------------------------------------
>
> Key: CASSANDRA-3152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3152
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.6
>
> Attachments: 0001-fix-dc-rack-sorting-on-ANTS.patch
>
>
> Current logic in ANTS.cE is to compare the rack and then compare the DC's, the problem is when we have the same rack name but the racks are in a diffrent DC's this logic breaks...
> Example:
> "us-east,1a", InetAddress.getByName("127.0.0.1")
> "us-east,1b", InetAddress.getByName("127.0.0.2")
> "us-east,1c", InetAddress.getByName("127.0.0.3")
> "us-west,1a", InetAddress.getByName("127.0.0.4")
> "us-west,1b", InetAddress.getByName("127.0.0.5")
> "us-west,1c", InetAddress.getByName("127.0.0.6")
> Expected:
> /127.0.0.1,/127.0.0.3,/127.0.0.2,/127.0.0.4,/127.0.0.5,/127.0.0.6
> Current:
> /127.0.0.1,/127.0.0.4,/127.0.0.3,/127.0.0.2,/127.0.0.5,/127.0.0.6
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3152) Logic of
AbstractNetworkTopologySnitch.compareEndpoints is wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099695#comment-13099695 ]
Hudson commented on CASSANDRA-3152:
-----------------------------------
Integrated in Cassandra-0.8 #320 (See [https://builds.apache.org/job/Cassandra-0.8/320/])
allow topology sort to work with non-unique rack names between datacenters
patch by Vijay; reviewed by jbellis for CASSANDRA-3152
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166484
Files :
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/locator/AbstractNetworkTopologySnitch.java
> Logic of AbstractNetworkTopologySnitch.compareEndpoints is wrong
> ----------------------------------------------------------------
>
> Key: CASSANDRA-3152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3152
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.6
>
> Attachments: 0001-fix-dc-rack-sorting-on-ANTS.patch
>
>
> Current logic in ANTS.cE is to compare the rack and then compare the DC's, the problem is when we have the same rack name but the racks are in a diffrent DC's this logic breaks...
> Example:
> "us-east,1a", InetAddress.getByName("127.0.0.1")
> "us-east,1b", InetAddress.getByName("127.0.0.2")
> "us-east,1c", InetAddress.getByName("127.0.0.3")
> "us-west,1a", InetAddress.getByName("127.0.0.4")
> "us-west,1b", InetAddress.getByName("127.0.0.5")
> "us-west,1c", InetAddress.getByName("127.0.0.6")
> Expected:
> /127.0.0.1,/127.0.0.3,/127.0.0.2,/127.0.0.4,/127.0.0.5,/127.0.0.6
> Current:
> /127.0.0.1,/127.0.0.4,/127.0.0.3,/127.0.0.2,/127.0.0.5,/127.0.0.6
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3152) Logic of
AbstractNetworkTopologySnitch.compareEndpoints is wrong
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3152:
-----------------------------
Attachment: 0001-fix-dc-rack-sorting-on-ANTS.patch
Tested and passed basically moved the DC comparison logic up in ANTS
> Logic of AbstractNetworkTopologySnitch.compareEndpoints is wrong
> ----------------------------------------------------------------
>
> Key: CASSANDRA-3152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3152
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.4
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Fix For: 0.8.5
>
> Attachments: 0001-fix-dc-rack-sorting-on-ANTS.patch
>
>
> Current logic in ANTS.cE is to compare the rack and then compare the DC's, the problem is when we have the same rack name but the racks are in a diffrent DC's this logic breaks...
> Example:
> "us-east,1a", InetAddress.getByName("127.0.0.1")
> "us-east,1b", InetAddress.getByName("127.0.0.2")
> "us-east,1c", InetAddress.getByName("127.0.0.3")
> "us-west,1a", InetAddress.getByName("127.0.0.4")
> "us-west,1b", InetAddress.getByName("127.0.0.5")
> "us-west,1c", InetAddress.getByName("127.0.0.6")
> Expected:
> /127.0.0.1,/127.0.0.3,/127.0.0.2,/127.0.0.4,/127.0.0.5,/127.0.0.6
> Current:
> /127.0.0.1,/127.0.0.4,/127.0.0.3,/127.0.0.2,/127.0.0.5,/127.0.0.6
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira