You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/08 12:21:23 UTC

[GitHub] [logging-log4net] NicholasNoise commented on a change in pull request #67: Add FxCop.

NicholasNoise commented on a change in pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#discussion_r484872716



##########
File path: src/log4net/Appender/FileAppender.cs
##########
@@ -1409,7 +1429,10 @@ virtual protected void OpenFile(string fileName, bool append)
 		/// </remarks>
 		virtual protected void SetQWForFiles(Stream fileStream)
 		{
-			SetQWForFiles(new StreamWriter(fileStream, m_encoding));
+#pragma warning disable CA2000 // Dispose objects before losing scope

Review comment:
       I think we should refactor this somehow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org