[GitHub] [pinot] jasperjiaguo commented on pull request #10683: Refine the return error code of query killing

["jasperjiaguo (via GitHub)" <gi...@apache.org>]

jasperjiaguo commented on PR #10683:
URL: https://github.com/apache/pinot/pull/10683#issuecomment-1526151784

   > if we are changing the status code, should we consider a general guideline of response code? at the moment error query result and success query result and partial query results are all returning 200 which could be misleading.
   > 
   > it is definitely bigger than the scope of this PR but would like to raise the concern before we determine 205 (Reset content) as the proper return code. according to document:
   > 
   > ```
   > 205: The server successfully processed the request, asks that the requester reset its document view, and is not returning any content.
   > ```
   > 
   > which doesn't seems like what's associated with query killing
   
   @walterddr agreed, I think we should consider the error codes holistically sometime, it is indeed a bit misleading right now. This PR should not affect the future refactoring right? I don't think we depend on hard coded number here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org