[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

["luoping.zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713441#comment-17713441 ] 

luoping.zhang commented on CALCITE-5510:
----------------------------------------

https://issues.apache.org/jira/browse/CALCITE-5656 RelToSqlConverter has an error using ordinal ORDER BY

> RelToSqlConverter should use ordinal for ORDER BY if the dialect allows
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-5510
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5510
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: peng wang
>            Assignee: peng wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.34.0
>
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> For example:
> Query SQL is 
> {code:java}
> select a, sum(b) from table group by a order by 2{code}
> When we convert this sql to relNode and convert it back to SQL by RelToConverter, the result is:
> {code:java}
> select a, sum(b) from table group by a order by sum(b){code}
> But we want to keep order by column to ordinal.
> Would we add a switch in RelToConverter to control whether convert sort by column to expression or ordinal?
> Maybe we can use method isSortByOrdinal in dialect SqlConformance?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)