You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/10 12:18:09 UTC

[GitHub] [maven-mvnd] hashhar commented on a change in pull request #577: Set default max heap size to null

hashhar commented on a change in pull request #577:
URL: https://github.com/apache/maven-mvnd/pull/577#discussion_r781141901



##########
File path: common/src/main/java/org/mvndaemon/mvnd/common/Environment.java
##########
@@ -209,7 +209,7 @@
     /**
      * The <code>-Xmx</code> value to pass to the daemon
      */
-    MVND_MAX_HEAP_SIZE("mvnd.maxHeapSize", null, "2G", OptionType.MEMORY_SIZE, Flags.DISCRIMINATING),
+    MVND_MAX_HEAP_SIZE("mvnd.maxHeapSize", null, null, OptionType.MEMORY_SIZE, Flags.DISCRIMINATING | Flags.OPTIONAL),

Review comment:
       I assumed it's fine to keep the heap size as a discriminating flag still since the heap size cannot be changed on the fly and hence is useful to identify the client within the registry.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org