You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/08/15 17:40:35 UTC
Review Request 61668: Added support for kill policies to the default
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Vinod Kone.
Bugs: MESOS-6535
https://issues.apache.org/jira/browse/MESOS-6535
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182970
-----------------------------------------------------------
Fix it, then Ship it!
We could update the test now, to make it take less than 3 seconds to run.
src/launcher/default_executor.cpp
Lines 1005-1006 (original), 1024-1025 (patched)
<https://reviews.apache.org/r/61668/#comment258941>
I think it'd be useful to include the container and task ids.
- Gastón Kleiman
On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 5:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6535
> https://issues.apache.org/jira/browse/MESOS-6535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
>
>
> Diff: https://reviews.apache.org/r/61668/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/
-----------------------------------------------------------
(Updated Aug. 15, 2017, 8:37 p.m.)
Review request for mesos, Gastón Kleiman and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-6535
https://issues.apache.org/jira/browse/MESOS-6535
Repository: mesos
Description
-------
Review: https://reviews.apache.org/r/61668
Diffs (updated)
-----
src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/3/
Changes: https://reviews.apache.org/r/61668/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182994
-----------------------------------------------------------
src/launcher/default_executor.cpp
Line 1098 (original), 1122-1130 (patched)
<https://reviews.apache.org/r/61668/#comment258979>
I would move this to `kill()` so that the update can be sent in other kill paths as well (e.g., when one task in a group terminates and all others are killed by the executor)
- Vinod Kone
On Aug. 15, 2017, 6:59 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 6:59 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6535
> https://issues.apache.org/jira/browse/MESOS-6535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/61668
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
>
>
> Diff: https://reviews.apache.org/r/61668/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/
-----------------------------------------------------------
(Updated Aug. 15, 2017, 6:59 p.m.)
Review request for mesos, Gastón Kleiman and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-6535
https://issues.apache.org/jira/browse/MESOS-6535
Repository: mesos
Description (updated)
-------
Review: https://reviews.apache.org/r/61668
Diffs (updated)
-----
src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
Diff: https://reviews.apache.org/r/61668/diff/2/
Changes: https://reviews.apache.org/r/61668/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Anand Mazumdar <an...@apache.org>.
> On Aug. 15, 2017, 6:09 p.m., Gastón Kleiman wrote:
> > src/launcher/default_executor.cpp
> > Line 995 (original), 1001 (patched)
> > <https://reviews.apache.org/r/61668/diff/1/?file=1798016#file1798016line1001>
> >
> > We should send a TASK_KILLING update here, and address the TODOs added by AlexR.
Good catch! I had missed that since I sent out this patch before updating the tests.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182974
-----------------------------------------------------------
On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 5:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6535
> https://issues.apache.org/jira/browse/MESOS-6535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
>
>
> Diff: https://reviews.apache.org/r/61668/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61668: Added support for kill policies to the
default executor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182974
-----------------------------------------------------------
Fix it, then Ship it!
src/launcher/default_executor.cpp
Line 995 (original), 1001 (patched)
<https://reviews.apache.org/r/61668/#comment258945>
We should send a TASK_KILLING update here, and address the TODOs added by AlexR.
- Gastón Kleiman
On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 5:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6535
> https://issues.apache.org/jira/browse/MESOS-6535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92
>
>
> Diff: https://reviews.apache.org/r/61668/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>