You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/01 09:04:02 UTC

[GitHub] [incubator-devlake] long2ice opened a new pull request, #2910: feat: starrocks plugin support custom dsn

long2ice opened a new pull request, #2910:
URL: https://github.com/apache/incubator-devlake/pull/2910

   # Summary
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Does this close any open issues?
   Closes xx
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] long2ice commented on a diff in pull request #2910: feat: starrocks plugin support custom dsn

Posted by GitBox <gi...@apache.org>.
long2ice commented on code in PR #2910:
URL: https://github.com/apache/incubator-devlake/pull/2910#discussion_r960584313


##########
plugins/starrocks/starrocks.go:
##########
@@ -59,6 +59,8 @@ var PluginEntry StarRocks
 
 func main() {
 	cmd := &cobra.Command{Use: "StarRocks"}
+	sourceType := cmd.Flags().StringP("source_type", "sp", "", "Source type")

Review Comment:
   已修复



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2910: feat: starrocks plugin support custom dsn

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2910:
URL: https://github.com/apache/incubator-devlake/pull/2910#discussion_r960580308


##########
plugins/starrocks/starrocks.go:
##########
@@ -59,6 +59,8 @@ var PluginEntry StarRocks
 
 func main() {
 	cmd := &cobra.Command{Use: "StarRocks"}
+	sourceType := cmd.Flags().StringP("source_type", "sp", "", "Source type")

Review Comment:
   这里用sp是因为st用过了吗？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 merged pull request #2910: feat: starrocks plugin support custom dsn

Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2910:
URL: https://github.com/apache/incubator-devlake/pull/2910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org