You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "zhaoyansheng163 (via GitHub)" <gi...@apache.org> on 2023/02/02 14:58:53 UTC
[GitHub] [incubator-eventmesh] zhaoyansheng163 opened a new pull request, #3031: fix #2970
zhaoyansheng163 opened a new pull request, #3031:
URL: https://github.com/apache/incubator-eventmesh/pull/3031
fix #2970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on pull request #3031: fix #2970
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on PR #3031:
URL: https://github.com/apache/incubator-eventmesh/pull/3031#issuecomment-1414503997
Please, fix checks failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on pull request #3031: [ISSUE #2970] Method invocation 'getRetCode' may produce 'NullPointerException'[AbstractProducerHttpClient]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3031:
URL: https://github.com/apache/incubator-eventmesh/pull/3031#issuecomment-1414757596
> fix #2970
@zhaoyansheng163 Issue and pr don't match, don't fix multiple issues in one pr, just submit the pr according to the issue you received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3031: fix #2970
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3031:
URL: https://github.com/apache/incubator-eventmesh/pull/3031#issuecomment-1413954522
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3031](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a11b572) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/bf8f3e1cd3c78aa3ba1158e5873d4cba8d8437c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf8f3e1) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head a11b572 differs from pull request most recent head 12356ab. Consider uploading reports for the commit 12356ab to get more accurate results
```diff
@@ Coverage Diff @@
## master #3031 +/- ##
============================================
- Coverage 12.84% 12.84% -0.01%
Complexity 1095 1095
============================================
Files 548 548
Lines 28615 28612 -3
Branches 2841 2838 -3
============================================
- Hits 3676 3674 -2
+ Misses 24645 24643 -2
- Partials 294 295 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntmesh/client/http/AbstractProducerHttpClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvQWJzdHJhY3RQcm9kdWNlckh0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../admin/handler/QueryRecommendEventMeshHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlSZWNvbW1lbmRFdmVudE1lc2hIYW5kbGVyLmphdmE=) | `88.88% <0.00%> (-3.71%)` | :arrow_down: |
| [.../trace/pinpoint/exporter/PinpointSpanExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtcGlucG9pbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC90cmFjZS9waW5wb2ludC9leHBvcnRlci9QaW5wb2ludFNwYW5FeHBvcnRlci5qYXZh) | `68.45% <0.00%> (-0.68%)` | :arrow_down: |
| [...sh/client/http/producer/EventMeshHttpProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvcHJvZHVjZXIvRXZlbnRNZXNoSHR0cFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...untime/core/protocol/http/push/HTTPClientPool.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0hUVFBDbGllbnRQb29sLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...otocol/meshmessage/MeshMessageProtocolAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9NZXNoTWVzc2FnZVByb3RvY29sQWRhcHRvci5qYXZh) | `3.84% <0.00%> (+0.07%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] zhaoyansheng163 closed pull request #3031: [ISSUE #2970] Method invocation 'getRetCode' may produce 'NullPointerException'[AbstractProducerHttpClient]
Posted by "zhaoyansheng163 (via GitHub)" <gi...@apache.org>.
zhaoyansheng163 closed pull request #3031: [ISSUE #2970] Method invocation 'getRetCode' may produce 'NullPointerException'[AbstractProducerHttpClient]
URL: https://github.com/apache/incubator-eventmesh/pull/3031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org