You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "SamWheating (via GitHub)" <gi...@apache.org> on 2023/08/24 17:40:41 UTC
[GitHub] [airflow] SamWheating opened a new pull request, #33702: Inspect container state rather than last_state when deciding whether to skip
SamWheating opened a new pull request, #33702:
URL: https://github.com/apache/airflow/pull/33702
closes: https://github.com/apache/airflow/issues/33697
Looking at the [Kubernetes API Docs for containerStatus](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#containerstatus-v1-core), it looks like `lastState` provides the state of the previous run of the container, whereas `state` should provide information on the most recent termination (which is the relevant one in this case)
I also added an integration test under `kubernetes_tests` to verify that this works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33702: Inspect container state rather than last_state when deciding whether to skip
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33702:
URL: https://github.com/apache/airflow/pull/33702#discussion_r1304694928
##########
kubernetes_tests/test_kubernetes_pod_operator.py:
##########
@@ -225,6 +225,22 @@ def test_delete_operator_pod(self, mock_get_connection):
assert self.expected_pod["spec"] == actual_pod["spec"]
assert self.expected_pod["metadata"]["labels"] == actual_pod["metadata"]["labels"]
+ def test_skip_on_specified_exit_code(self, mock_get_connection):
Review Comment:
:heart: the integration test !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33702: Inspect container state rather than last_state when deciding whether to skip
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33702:
URL: https://github.com/apache/airflow/pull/33702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org