You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Bruce Schuchardt (JIRA)" <ji...@apache.org> on 2018/02/27 22:59:00 UTC
[jira] [Created] (GEODE-4749) change AnalyzeSerializables to not
store method bytecodes in sanctioned/actual files
Bruce Schuchardt created GEODE-4749:
---------------------------------------
Summary: change AnalyzeSerializables to not store method bytecodes in sanctioned/actual files
Key: GEODE-4749
URL: https://issues.apache.org/jira/browse/GEODE-4749
Project: Geode
Issue Type: Bug
Components: serialization
Reporter: Bruce Schuchardt
AnalyzeSerializables stores a string representation of the bytecodes of the toData/fromData methods in sanctionedDataSerializables.txt and actualDataSerializables.dat but it only pays attention to the number of bytecodes when detecting changes to these methods. Many of the bytecode strings are now out of date. Though the methods have the same number of bytecodes the actual code generated by the compiler is different now than it used to be.
We need to change the ClassAndMethodDetails class to only care about the number of bytecodes and not hold onto the bytes themselves. Then regenerate all of the sanctionedDataSerializables.txt files in the various modules (run the test and copy the actualDataSerializables.dat file over the sanctionedDataSerializables.txt file). This will help our git pull request diffs be compact and understandable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)