You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Massimo Lusetti (JIRA)" <ji...@apache.org> on 2010/01/15 10:47:54 UTC
[jira] Created: (TAP5-987) New ValidationTrackerWrapper somehow has
changed behaviour of form validation
New ValidationTrackerWrapper somehow has changed behaviour of form validation
-----------------------------------------------------------------------------
Key: TAP5-987
URL: https://issues.apache.org/jira/browse/TAP5-987
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.0, 5.2
Reporter: Massimo Lusetti
The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
This seems to cause a regression in the way form validation is processed.
The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
With this changes the event path goes always from validate to success events, the failure event is never fired.
The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-987) New ValidationTrackerWrapper somehow
has changed behaviour of form validation
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-987:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-987) In some cases you can invoke
Form.recordError() and the Form will still fire a success (not a failure)
event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-987:
--------------------------------------
Summary: In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event (was: New ValidationTrackerWrapper somehow has changed behaviour of form validation)
> In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event
> ------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-987) In some cases you can invoke
Form.recordError() and the Form will still fire a success (not a failure)
event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-987.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
> In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event
> ------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.2.0
>
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-987) New ValidationTrackerWrapper somehow has
changed behaviour of form validation
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti updated TAP5-987:
---------------------------------
Priority: Critical (was: Major)
I think this issue got to have an higher priority...
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-987) New ValidationTrackerWrapper somehow
has changed behaviour of form validation
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828418#action_12828418 ]
Howard M. Lewis Ship commented on TAP5-987:
-------------------------------------------
There's a code path wherein invoking Form.recordError() (from inside a validate method) would record the error into a new instance of ValidationTrackerImpl, and the existing instance (used to check to see whether to invoke success or failure event) would not be aware of the recorded errors.
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-987) In some cases you can invoke
Form.recordError() and the Form will still fire a success (not a failure)
event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-987:
--------------------------------------
Summary: In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event (was: New ValidationTrackerWrapper somehow has changed behaviour of form validation)
> In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event
> ------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-987) New ValidationTrackerWrapper somehow has
changed behaviour of form validation
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti updated TAP5-987:
---------------------------------
Priority: Critical (was: Major)
I think this issue got to have an higher priority...
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-987) In some cases you can invoke
Form.recordError() and the Form will still fire a success (not a failure)
event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-987.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
> In some cases you can invoke Form.recordError() and the Form will still fire a success (not a failure) event
> ------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.2.0
>
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-987) New ValidationTrackerWrapper somehow
has changed behaviour of form validation
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-987:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-987) New ValidationTrackerWrapper somehow
has changed behaviour of form validation
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828418#action_12828418 ]
Howard M. Lewis Ship commented on TAP5-987:
-------------------------------------------
There's a code path wherein invoking Form.recordError() (from inside a validate method) would record the error into a new instance of ValidationTrackerImpl, and the existing instance (used to check to see whether to invoke success or failure event) would not be aware of the recorded errors.
> New ValidationTrackerWrapper somehow has changed behaviour of form validation
> -----------------------------------------------------------------------------
>
> Key: TAP5-987
> URL: https://issues.apache.org/jira/browse/TAP5-987
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0, 5.2
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> The changes introduced into r898476 to address TAP5-979 has introduced the new ValidationTrackerWrapper.
> This seems to cause a regression in the way form validation is processed.
> The old (and wanted) way is to have onValidate to check for form-wide validations and store into the form (form.recordErorr) any found violation. Then if there are violations (errors recorded) the form fire the onFailure events otherwise go to onSuccess.
> With this changes the event path goes always from validate to success events, the failure event is never fired.
> The only possible workaround is to have the onFailure event handler method to return an object (typically this) and never be of type void.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.