[GitHub] [geode] jinmeiliao opened pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["jinmeiliao (GitHub)" <gi...@apache.org>]

* file saving should be handled by the command's postExecutor to save to appropriate places
* after saving file content to a directory already, the ResultModel turned the FileResultModel into InfoResultModel.
* gfsh should not be the place to save files in ModelCommandResult.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["pdxrunner (GitHub)" <gi...@apache.org>]

Will this test pass on Windows?

[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["pdxrunner (GitHub)" <gi...@apache.org>]

For this and the following test `mytemp` is created in the `tempFolder` so explicit deletion shouldn't be necessary.

[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["pdxrunner (GitHub)" <gi...@apache.org>]

Thanks. I stand corrected.

[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2460: GEODE-5727: rework how ResultModel deal with file contents.

["jinmeiliao (GitHub)" <gi...@apache.org>]

actually the exported files without absolute paths is written to the user.dir, so we need an explicit delete both here and the test below. The test below is deleting the wrong file. I checked a fix for that.

[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org