You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:14:22 UTC

[GitHub] [dubbo] kylixs opened a new pull request #8430: [3.0] compatible with spring 3.2.x and add tests

kylixs opened a new pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430


   ## What is the purpose of the change
   
   compatible with spring 3.2.x and add tests
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.17%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.04%   -0.18%     
     Complexity      312      312              
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29281      +55     
   - Misses        13735    13883     +148     
   - Partials       3269     3282      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.16%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.05%   -0.17%     
     Complexity      312      312              
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29287      +61     
   - Misses        13735    13879     +144     
   - Partials       3269     3280      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.28%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   62.92%   -0.29%     
   + Complexity      312      311       -1     
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29228       +2     
   - Misses        13735    13932     +197     
   - Partials       3269     3286      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [49 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.31%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   62.89%   -0.32%     
   + Complexity      312      311       -1     
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46400     +170     
     Branches       6978     6967      -11     
   ============================================
   - Hits          29226    29185      -41     
   - Misses        13735    13925     +190     
   - Partials       3269     3290      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [67 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.11%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.10%   -0.12%     
   - Complexity      312      313       +1     
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29309      +83     
   - Misses        13735    13862     +127     
   - Partials       3269     3275       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.11%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.09%   -0.12%     
   - Complexity      312      313       +1     
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29307      +81     
   - Misses        13735    13863     +128     
   - Partials       3269     3276       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [39 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.16%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.05%   -0.17%     
     Complexity      312      312              
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29287      +61     
   - Misses        13735    13879     +144     
   - Partials       3269     3280      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#discussion_r684050293



##########
File path: dubbo-test/dubbo-test-spring4.2/pom.xml
##########
@@ -0,0 +1,70 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+  -->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>dubbo-test</artifactId>
+        <groupId>org.apache.dubbo</groupId>
+        <version>${revision}</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>dubbo-test-spring4.2</artifactId>
+
+    <properties>
+        <spring_version>4.2.4.RELEASE</spring_version>

Review comment:
       please add maven skip deploy property




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8430: [3.0] compatible with spring 3.2.x and add tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8430:
URL: https://github.com/apache/dubbo/pull/8430#issuecomment-895041579


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8430](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f89ed2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/75443e1c8e842c2ce700e7dd4d01a16921edd278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75443e1) will **decrease** coverage by `0.14%`.
   > The diff coverage is `26.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8430/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8430      +/-   ##
   ============================================
   - Coverage     63.21%   63.07%   -0.15%     
   - Complexity      312      313       +1     
   ============================================
     Files          1103     1111       +8     
     Lines         46230    46446     +216     
     Branches       6978     7000      +22     
   ============================================
   + Hits          29226    29295      +69     
   - Misses        13735    13874     +139     
   - Partials       3269     3277       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `60.00% <0.00%> (-22.00%)` | :arrow_down: |
   | [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `85.36% <ø> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/test/common/EmbeddedZooKeeper.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vRW1iZWRkZWRab29LZWVwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...in/java/org/apache/dubbo/test/common/SysProps.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vU3lzUHJvcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/test/common/ZooKeeperServer.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vWm9vS2VlcGVyU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/test/common/impl/DemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/test/common/impl/RestDemoServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9SZXN0RGVtb1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/dubbo/config/spring/util/SpringCompatUtils.java](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9TcHJpbmdDb21wYXRVdGlscy5qYXZh) | `28.57% <28.57%> (ø)` | |
   | ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/8430/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [75443e1...2f89ed2](https://codecov.io/gh/apache/dubbo/pull/8430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org