[GitHub] Jackie-Jiang commented on a change in pull request #3704: Fix SegmentStatusChecker exception

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #3704: Fix SegmentStatusChecker exception
URL: https://github.com/apache/incubator-pinot/pull/3704#discussion_r248512866
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1926,6 +1926,24 @@ public boolean hasOfflineTable(String tableName) {
     return getAllTables().contains(actualTableName);
   }
 
+  /**
+   * Gets the ideal state of the table
+   * @param tableNameWithType
 
 Review comment:
   [Minor] If we are not going to add doc for param and return, remove these 2 lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org