You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/05/18 06:43:23 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #264: [YUNIKORN-591] move TaskGroupInstanceCountMap to its own file

yangwwei commented on a change in pull request #264:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/264#discussion_r634086314



##########
File path: pkg/common/utils/gang_TGInstanceCountMap.go
##########
@@ -0,0 +1,93 @@
+/*

Review comment:
       this file name is too long. Since we have a short term "tg" for task group, I suggest renaming this file to:  `tg_map.go`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org