You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 15:40:22 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #2287: Add BatchPartitioner (#2285)

Dandandan commented on code in PR #2287:
URL: https://github.com/apache/arrow-datafusion/pull/2287#discussion_r854287956


##########
datafusion/core/src/physical_plan/repartition.rs:
##########
@@ -87,7 +87,7 @@ impl BatchPartitioner {
     /// Create a new [`BatchPartitioner`] with the provided [`Partitioning`]
     ///
     /// The time spent repartitioning will be recorded to `timer`
-    pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Self {
+    pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Result<Self> {

Review Comment:
   Shouldn´t this be `try_new` now by convention?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org