You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/11 13:56:47 UTC
Review Request 43480: [WIP]Use in_memory as default registry when
testing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43480/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4647
https://issues.apache.org/jira/browse/MESOS-4647
Repository: mesos
Description
-------
Use in_memory as default registry when testing.
Diffs
-----
src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f
src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c
Diff: https://reviews.apache.org/r/43480/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43480: Use in_memory as default registry when
testing.
Posted by haosdent huang <ha...@gmail.com>.
> On April 8, 2016, 2:23 p.m., Alexander Rukletsov wrote:
> > Joris started a similar effort some time ago: https://reviews.apache.org/r/41665/
Got it. Let me discard mine.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43480/#review127790
-----------------------------------------------------------
On Feb. 11, 2016, 4:02 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43480/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 4:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use in_memory as default registry when testing.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
> src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f
> src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c
>
> Diff: https://reviews.apache.org/r/43480/diff/
>
>
> Testing
> -------
>
> sudo test in CentOS 7.1
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43480: Use in_memory as default registry when
testing.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43480/#review127790
-----------------------------------------------------------
Joris started a similar effort some time ago: https://reviews.apache.org/r/41665/
- Alexander Rukletsov
On Feb. 11, 2016, 4:02 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43480/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 4:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use in_memory as default registry when testing.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
> src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f
> src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c
>
> Diff: https://reviews.apache.org/r/43480/diff/
>
>
> Testing
> -------
>
> sudo test in CentOS 7.1
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43480: Use in_memory as default registry when
testing.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43480/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 4:02 p.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
Use in_memory as default registry when testing.
Bugs: MESOS-4647
https://issues.apache.org/jira/browse/MESOS-4647
Repository: mesos
Description
-------
Use in_memory as default registry when testing.
Diffs
-----
src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f
src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c
Diff: https://reviews.apache.org/r/43480/diff/
Testing (updated)
-------
sudo test in CentOS 7.1
Thanks,
haosdent huang
Re: Review Request 43480: [WIP]Use in_memory as default registry when
testing.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43480/#review118856
-----------------------------------------------------------
Bad patch!
Reviews applied: [43480]
Failed command: ./support/apply-review.sh -n -r 43480
Error:
2016-02-11 13:09:41 URL:https://reviews.apache.org/r/43480/diff/raw/ [3045/3045] -> "43480.patch" [1]
Total errors found: 0
Checking 3 files
Error: Commit message summary (the first line) must start with a capital letter.
Full log: https://builds.apache.org/job/mesos-reviewbot/11387/console
- Mesos ReviewBot
On Feb. 11, 2016, 12:56 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43480/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:56 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use in_memory as default registry when testing.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
> src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f
> src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c
>
> Diff: https://reviews.apache.org/r/43480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>