You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/06 09:57:37 UTC
[GitHub] [camel-website] AghaSaad04 opened a new pull request #167: Fixed
right/left margin issue
AghaSaad04 opened a new pull request #167: Fixed right/left margin issue
URL: https://github.com/apache/camel-website/pull/167
Signed-off-by: Agha Saad Fraz <ag...@gmail.com>
Issue:
Article containers right margin is larger than the left margin
Solution:
The issue was with the max-width property of the "doc" class. It was limiting the content to 46em max-width. I have removed the max-width property and now the result is:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #167: Fixed
right/left margin issue
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #167: Fixed right/left margin issue
URL: https://github.com/apache/camel-website/pull/167#issuecomment-595727165
Sure, thanks @zregvart. I will look more into this. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #167: Fixed right/left
margin issue
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #167: Fixed right/left margin issue
URL: https://github.com/apache/camel-website/pull/167#issuecomment-595726524
@AghaSaad04 thank you for your contribution.
We have the "Wide / Narrow" link at the top right of the page that toggles between the wide or narrow (default) widths of text. We discussed this before on #94 and #107. The solution you propose breaks the "Wide / Narrow" functionality.
I'm still uncertain if we should have the content centered or offer the wider view of the text by default. There's a comment on [the issue](https://issues.apache.org/jira/browse/CAMEL-13881?focusedCommentId=17053138&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17053138) about this.
I would appreciate some research on this topic with regards to readability and usability to help reach a decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #167: Fixed
right/left margin issue
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #167: Fixed right/left margin issue
URL: https://github.com/apache/camel-website/pull/167#issuecomment-595693851
I am thinking of removing these variables from the vars.css file as well. Should I do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 closed pull request #167: Fixed
right/left margin issue
Posted by GitBox <gi...@apache.org>.
AghaSaad04 closed pull request #167: Fixed right/left margin issue
URL: https://github.com/apache/camel-website/pull/167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services