You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 06:34:40 UTC
[GitHub] [airflow] uranusjr opened a new pull request #17544: Rescure if a DagRun's DAG was removed from db
uranusjr opened a new pull request #17544:
URL: https://github.com/apache/airflow/pull/17544
Fix #17442.
The exception happens when a DAG is removed from the database (via web UI or something else), but there are still unfinished runs associated to it. This catches the scenario and use the existing fallback setting `max_active_runs` to zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17544: Rescure if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17544:
URL: https://github.com/apache/airflow/pull/17544#issuecomment-896861484
Should we add a test for this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17544: Rescure if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17544:
URL: https://github.com/apache/airflow/pull/17544#issuecomment-897538890
Writing a proper test turns out to be a long journey figuring out a right combination to trigger this bug. So to trigger this bug, a DAG should _not_ be in the DagBag, but _in_ the DagModel table, but _not_ in the SerializedDagModel table.
@georborodin Does the DAG you deleted from the web UI have subdags? This is the only situation I’ve managed to set up a proper environment for the test. (Although I wouldn’t be surprised if there’s more I couldn’t locate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17544: Rescue if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17544:
URL: https://github.com/apache/airflow/pull/17544#issuecomment-898243405
For future reference, the complete steps to reproduce this from the web UI is:
1. Create a DAG with a subDAG that runs for a long-ish time. Wait for them to show up in the web UI.
2. Run the DAG (thus trigging the subDAG).
3. delete the parent DAG from the web UI. (This does not delete the subDAG.)
4. Try to block the subDAG’s unfinished run from step 2. (Should fail with `SerializedDagNotFound` before this patch.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17544: Rescure if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17544:
URL: https://github.com/apache/airflow/pull/17544#issuecomment-896964885
Good point, I'll add one (and fix the typo in the commit message 🤦♂️)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17544: Rescue if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17544:
URL: https://github.com/apache/airflow/pull/17544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17544: Rescure if a DagRun's DAG was removed from db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17544:
URL: https://github.com/apache/airflow/pull/17544#issuecomment-896574037
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org