You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/03 21:37:16 UTC
[PR] [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0 [spark]
dongjoon-hyun opened a new pull request, #58507:
URL: https://github.com/apache/spark/pull/58507
### What changes were proposed in this pull request?
This PR fixes the version metadata of the `variant_delete` expression, which was incorrectly recorded as `5.0.0` instead of `4.3.0`.
Four places are corrected:
| File | Item |
| --- | --- |
| `sql/catalyst/.../variant/variantExpressions.scala` | `VariantDelete`'s `@ExpressionDescription(since = ...)` |
| `sql/api/.../functions.scala` | `@since` of `variant_delete(Column, Column, Column*)` |
| `sql/api/.../functions.scala` | `@since` of `variant_delete(Column, String, String*)` |
| `python/pyspark/sql/functions/builtin.py` | `.. versionadded::` |
`python/pyspark/sql/connect/functions/builtin.py` needs no change since it reuses the classic docstring via `variant_delete.__doc__ = pysparkfuncs.variant_delete.__doc__`.
### Why are the changes needed?
`variant_delete` was added by [SPARK-57417](https://issues.apache.org/jira/browse/SPARK-57417) (`77d302a1d5a`, 2026-06-17) and backported to `branch-4.3` as `38e2143defa`, so it first ships in Apache Spark 4.3.0, not 5.0.0. The commit is already contained in the [v4.3.0-rc1](https://github.com/apache/spark/releases/tag/v4.3.0-rc1) tag (2026-08-31).
The wrong version misleads users about the minimum Spark version required to use this function, and it is surfaced publicly through the SQL built-in function documentation, the Scala API Scaladoc, and the PySpark API docs.
### Does this PR introduce _any_ user-facing change?
No behavior change. This only corrects the documented availability version of `variant_delete` from `5.0.0` to `4.3.0`. Since `variant_delete` has not been released yet, this is a correction within unreleased branches only.
### How was this patch tested?
Documentation metadata change only, no logic is touched. Existing tests for `variant_delete` (`VariantExpressionSuite`, `VariantSuite`, `PlanGenerationTestSuite`, and the PySpark doctests) continue to cover the function.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58507:
URL: https://github.com/apache/spark/pull/58507#issuecomment-5533920608
Thank you, @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58507: [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0
URL: https://github.com/apache/spark/pull/58507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58507:
URL: https://github.com/apache/spark/pull/58507#issuecomment-5532494887
cc @cloud-fan , @bojana-db , @HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57417][SQL][PYTHON][FOLLOWUP] Fix the `variant_delete` version to 4.3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58507:
URL: https://github.com/apache/spark/pull/58507#issuecomment-5533925161
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/908903a992a682c52d3a4081f8f3df614aaab45f
- merged into branch-4.x https://github.com/apache/spark/commit/2c3b616afa967fb3ef0190dc4e5c7945983db976
- merged into branch-4.3 https://github.com/apache/spark/commit/02c18c1b6850dd6ada7c9446efe5a3df749e0000
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org