You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "bdoyle0182 (via GitHub)" <gi...@apache.org> on 2023/02/24 04:55:59 UTC

[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5384: attempt to fix downstream runtime builds

bdoyle0182 opened a new pull request, #5384:
URL: https://github.com/apache/openwhisk/pull/5384

   ## Description
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Scheduler
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   - [X] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk] bdoyle0182 commented on pull request #5384: attempt to fix downstream runtime builds

Posted by "bdoyle0182 (via GitHub)" <gi...@apache.org>.
bdoyle0182 commented on PR #5384:
URL: https://github.com/apache/openwhisk/pull/5384#issuecomment-1444113533

   > I think it made progress, but we're not out of the woods yet. Here's the snippet from the re-run of runttime-go (https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068)
   > 
   > ```
   > > Task :tests:test FAILED
   > [30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
   > FAILURE: Build failed with an exception.
   > [31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)
   > 
   > [32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
   > * What went wrong:
   > [33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
   > Execution failed for task ':tests:test'.
   > [34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
   > > Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
   > [35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
   >    > Could not find com.atlassian.oai:swagger-request-validator-core:.
   > [36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
   >      Required by:
   > [37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
   >          project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
   > [38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
   >    > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
   > [39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
   >      Required by:
   > [40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
   >          project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
   > ```
   
   will get the rest of the dependencies from that pr updated and then seems like hopefully it should be good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk] codecov-commenter commented on pull request #5384: attempt to fix downstream runtime builds

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5384:
URL: https://github.com/apache/openwhisk/pull/5384#issuecomment-1442869800

   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5384](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce08108) into [master](https://codecov.io/gh/apache/openwhisk/commit/65a0132e73b41528dcf5b2817a55a579f7900433?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65a0132) will **decrease** coverage by `71.93%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head ce08108 differs from pull request most recent head a15866f. Consider uploading reports for the commit a15866f to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #5384       +/-   ##
   ==========================================
   - Coverage   76.45%   4.53%   -71.93%     
   ==========================================
     Files         240     240               
     Lines       14569   14569               
     Branches      647     647               
   ==========================================
   - Hits        11139     660    -10479     
   - Misses       3430   13909    +10479     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../main/scala/org/apache/openwhisk/core/WarmUp.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2FybVVwLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3NwaS9TcGlMb2FkZXIuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...n/scala/org/apache/openwhisk/utils/JsHelpers.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL0pzSGVscGVycy5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/common/Prometheus.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Qcm9tZXRoZXVzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/common/time/Clock.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90aW1lL0Nsb2NrLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/core/FeatureFlags.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvRmVhdHVyZUZsYWdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...scala/org/apache/openwhisk/http/CorsSettings.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQ29yc1NldHRpbmdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ala/org/apache/openwhisk/common/ConfigMXBean.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNWEJlYW4uc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...la/org/apache/openwhisk/http/BasicRasService.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/openwhisk/common/ConfigMapValue.scala](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNYXBWYWx1ZS5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [194 more](https://codecov.io/gh/apache/openwhisk/pull/5384?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk] dgrove-oss merged pull request #5384: attempt to fix downstream runtime builds

Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss merged PR #5384:
URL: https://github.com/apache/openwhisk/pull/5384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk] dgrove-oss commented on pull request #5384: attempt to fix downstream runtime builds

Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss commented on PR #5384:
URL: https://github.com/apache/openwhisk/pull/5384#issuecomment-1443756648

   I'll rerun one of the downstream runtime jobs manually and see what happens...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk] dgrove-oss commented on pull request #5384: attempt to fix downstream runtime builds

Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss commented on PR #5384:
URL: https://github.com/apache/openwhisk/pull/5384#issuecomment-1443777619

   I think it made progress, but we're not out of the woods yet.  Here's the snippet from the re-run of runttime-go.
   
   ```
   > Task :tests:test FAILED
   [30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
   FAILURE: Build failed with an exception.
   [31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)
   
   [32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
   * What went wrong:
   [33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
   Execution failed for task ':tests:test'.
   [34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
   > Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
   [35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
      > Could not find com.atlassian.oai:swagger-request-validator-core:.
   [36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
        Required by:
   [37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
            project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
   [38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
      > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
   [39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
        Required by:
   [40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
            project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org