You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/13 06:17:46 UTC

[GitHub] [servicecomb-service-center] jeho0815 commented on a change in pull request #662: remove grpc support

jeho0815 commented on a change in pull request #662:
URL: https://github.com/apache/servicecomb-service-center/pull/662#discussion_r453455660



##########
File path: server/service/rbac/dao/account_dao.go
##########
@@ -55,7 +56,11 @@ func CreateAccount(ctx context.Context, a *rbacframe.Account) error {
 	if exist {
 		return ErrDuplicated
 	}
-
+	a.Password, err = cipher.Encrypt(a.Password)

Review comment:
       密码直接hash保存？后面只需要比较是否一致，不需要知道明文信息吧




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org